karutaproject / karuta-backend_legacy

Data repository for Karuta. Can write into MySQL and Oracle databases.
Other
10 stars 15 forks source link

Wrong pattern #83

Open jgribonvald opened 2 years ago

jgribonvald commented 2 years ago

When I read this code there should be an issue here https://github.com/karutaproject/karuta-backend_legacy/blob/3bd407c4c7cf9cedcb161e8e3fcadec54b448fd4/src/com/portfolio/data/attachment/ExportHTMLService.java#L168

the pattern should be

datastr = datastr.replaceAll("href=\"[^\"]*(/[^\"]*.((css)|(less))\")", "href=\"css$1");

as brackets are for listing chars

How to test the change ?

nobry commented 2 years ago

I don't remember exactly where, but there was a function to export the portfolio in the UI. Also there was a lot of changes in the interface so there's good chances the function is broken.