search

karvulf / flutter-reorderable-grid-view

BSD 3-Clause "New" or "Revised" License
158 stars 23 forks source link

5.3.1 breaks reordering #137

Closed isenbj closed 1 month ago

isenbj commented 1 month ago

See video. This is a list of reorderable grid views in the first page of a PageView.builder. It worked perfectly fine before. Seems that scrolling down some breaks things.

https://youtu.be/AmYe9iK18G8

karvulf commented 1 month ago

Hi @isenbj Unfortunately I cannot see the video. Is it the same code you showed the last time? I am also fixing an issue which was found here #135 , maybe it’s related

isenbj commented 1 month ago

The video seems to have gotten stuck. Try this one.

https://youtu.be/dSKMva2Gj0U

The other issue I mentioned I have not been able to break it down to be reproducible yet.

karvulf commented 1 month ago

Interesting, did you add a ScrollController to ReorderableBuilder? @isenbj

isenbj commented 1 month ago

Ahh, yes I did! Before I think it was needed so that I could drag down to other ReorderableBuilders and drop. But now it seems removing the ScrollController still works, and I am still able to drag down to other reorderables.

isenbj commented 1 month ago

Fantastic work by the way. As you can see in my app, it is a very nice addition.

karvulf commented 1 month ago

I created an issue to improve this behavior because it's a bit confusing currently. Your app looks really great, I am happy to see that it's working for you so well :) @isenbj