search

kas-catholic / confessit-web

Source code for https://confessit.app
MIT License
18 stars 7 forks source link

Remove pt duplicate translation #73

Closed kas-catholic closed 10 months ago

kas-catholic commented 10 months ago

We had duplicate translation files for pt and pt-BR. We're using pt-BR, so remove pt.

(See #71)

netlify[bot] commented 10 months ago

Deploy Preview for confessit-web ready!

Name Link
Latest commit 2a1d3fe3c99475c8c1bd9300d93d2ad51ea2aac4
Latest deploy log https://app.netlify.com/sites/confessit-web/deploys/648dc81d0cb03c000873f717
Deploy Preview https://deploy-preview-73--confessit-web.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

kas-catholic commented 10 months ago

@JohnRDOrazio I believe this is the best way to clean things up. Do we need to do anything on the Weblate side before or after I merge this?

JohnRDOrazio commented 10 months ago

Yes, I believe this should be done from weblate, since weblate has it's own internal database with the translation information. I'm not sure what would happen if you just do it from here: would weblate recreate it again? The sure way is to remove the translation from weblate. And that will be reflected in the next PR from weblate.

JohnRDOrazio commented 10 months ago

I suppose we can test to see what happens: go ahead and pull this, and we'll see how weblate responds. If it re-creates the pt translation, then we know that we just have to do it from weblate.

JohnRDOrazio commented 10 months ago

This actually seems to have worked, the pt translation is gone from weblate. We just wind up with an extra commit because weblate had to pull the change. If you want a slightly cleaner workflow with less commits, you would do it from weblate. In any case the final result is the same.