search

kas-gui / kas

Another GUI toolkit
Apache License 2.0
892 stars 27 forks source link

kas = {git = "https://github.com/kas-gui/kas"} is broken, winit patch is not applied #414

Closed m-hugo closed 8 months ago

m-hugo commented 8 months ago

adding master kas to a crate as

[dependencies]
kas = {git = "https://github.com/kas-gui/kas"}

fails because this patch from the root's Cargo.toml isn't applied so the regular winit v0.29.1-beta is used

[patch.crates-io.winit]
git = "https://github.com/rust-windowing/winit.git"
rev = "cb58c49a90f17734e0405627130674d47c0b8f40"

adding manually the patch to my crate's Cargo.toml made it work

dhardy commented 8 months ago

Thanks for the report; guess I shouldn't merge patches like that. It could be fixed (remove the patch, adjust the import in crates/kas-core/Cargo.toml instead), but hopefully Winit 0.29 won't be too long now: https://github.com/rust-windowing/winit/issues/2686