search

kas1e / Odyssey

AmigaOS4 version of Odyssey
9 stars 7 forks source link

Shortcut in URL Preferences #18

Open samo79 opened 4 years ago

samo79 commented 4 years ago

In the URL Preferences window, the shortcut in the string:

"Cookie Name Filter"

Doesn't work

javierdlr commented 4 years ago

Seems the problem is that the LabelObject and the StringObject aren't "linked"/binded (dunnot how to explain).

https://www.os4coding.net/forum/label-hotkey-not-working-some-string-gadgets

samo79 commented 4 years ago

Thanks to having look at :) If it's a MUI issue eventually i can even open a ticket there

javierdlr commented 4 years ago

It's not a MUI issue, is how is coded/created such LabelObject+StringObjects in Odyssey. It can be "fixed" and if you find/see other stringadgets that "need" it they can be changed to use "fixed" code.

samo79 commented 4 years ago

Ok understand I checked the entire translation many time and i believe this specific string was the only one

javierdlr commented 4 years ago

Looking at the prefs GUI and other prefs/settings window, it looks that you're right. Maybe just removing such shortcut is "clever" rather than searching for stringgadgets and see if they "need" a shortcut (and then modifying code to use "fixed" one). Just to keep some consistency on prefs window.

samo79 commented 4 years ago

For my italian translatiln I've added shortcuts in pratically every area of the prefs and in some specific place when i consider they can be usefull. Other area i leaved without, because they may conflict with the user typing..

Aniway I tried now to add shortcuts in a couple of checkboxes of the bookmark window:

Show in menu Quick link

Then tested, but apparently they doesn't work ... probably also that two were created in the same "broken" method of the one in url preferences ?

javierdlr commented 4 years ago

Ok, let my ask kas1e is it's worth the efort to "update" such stringgadets (already had "fixed" code, just need to update in odyssey code)

samo79 commented 4 years ago

Ok meanwhile I rechecked again the entire catalog and can confirm that there are only that 3 checkboxes that might need this modification in order to support eventual user shortcuts

Cookie Name Filter (in url prefs window) Show in menu (in bookmark window) Quick link (in bookmark window)