search

kas1e / Odyssey

AmigaOS4 version of Odyssey
9 stars 7 forks source link

Massive extension of list of enabled CSS properties and values. #30

Closed andresiegel closed 2 years ago

andresiegel commented 2 years ago

I have since tested it and Odyssey 1.23 has "grid layout" disabled by default.

There are significant related code portions missing compared to Odyssey 1.24 and later. I remember you made public statements in the past suggesting the Webkit version in Odyssey 1.24 would be an insignificant upgrade due to the small difference in age but "grid support" should not be underestimated.

If you have time to experiment with this, you might want to compile with these options (or variations thereof):

set(ENABLE_CSS_GRID_LAYOUT ON)

Also, as an extra: set(ENABLE_CSS_SHAPES ON)

That being said, even with grid support disabled, the CSS patches should still have significant effects. Websites like "google.com" (text in input field) or "allegro.pl" should look notably different due to their specific use of flexbox layouts.

Best regards, André

javierdlr commented 2 years ago

Hi, trying to build (crosscompile) I get this error: ... In file included from /home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSBasicShapes.cpp:34: /home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSPrimitiveValueMappings.h: In constructor ‘WebCore::CSSPrimitiveValue::CSSPrimitiveValue(T) [with T = WebCore::EDisplay]’: /home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSPrimitiveValueMappings.h:1347:10: error: ‘WEBKIT_FLEX’ was not declared in this scope; did you mean ‘WEBKIT_LEFT’? 1347 | case WEBKIT_FLEX: // andresiegel | ^~~ | WEBKIT_LEFT ...

https://github.com/kas1e/Odyssey/issues/31

andresiegel commented 2 years ago

As a quick fix, I would recommend to revert this specific file to its prior state but leave the other two updated files as-is.

Fortunately, leaving out this file should not have too much of an effect in any case.

On 8. Jun 2022, at 10:42, Javier de las Rivas @.***> wrote:

Hi, trying to build (crosscompile) I get this error: ... In file included from /home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSBasicShapes.cpp:34: /home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSPrimitiveValueMappings.h: In constructor ‘WebCore::CSSPrimitiveValue::CSSPrimitiveValue(T) [with T = WebCore::EDisplay]’: /home/usuario/amiga/Odyssey/odyssey-r155188-1.23/Source/WebCore/css/CSSPrimitiveValueMappings.h:1347:10: error: ‘WEBKIT_FLEX’ was not declared in this scope; did you mean ‘WEBKIT_LEFT’? 1347 | case WEBKIT_FLEX: // andresiegel | ^~~ | WEBKIT_LEFT ...

31 https://github.com/kas1e/Odyssey/issues/31

— Reply to this email directly, view it on GitHub https://github.com/kas1e/Odyssey/pull/30#issuecomment-1149632608, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD77KKML6G2GQTK4K6RKOBLVOBMHTANCNFSM5PXIA46Q. You are receiving this because you authored the thread.

javierdlr commented 2 years ago

THX, will do it ASAP an post here result, BTW I added those "new" options into "main" CMakeLists.txt: set(ENABLE_CSS_GRID_LAYOUT ON) set(ENABLE_CSS_SHAPES ON)

Is it ok? Will see what I get.

andresiegel commented 2 years ago

It’s certainly worth giving this a try but there are strong indications that “grid” support may be largely unfinished in the Webkit version used by Odyssey v1.23.

On 8. Jun 2022, at 12:43, Javier de las Rivas @.***> wrote:

THX, will do it ASAP an post here result, BTW I added those "new" options into "main" CMakeLists.txt: set(ENABLE_CSS_GRID_LAYOUT ON) set(ENABLE_CSS_SHAPES ON)

Is it ok? Will see what I get.

— Reply to this email directly, view it on GitHub https://github.com/kas1e/Odyssey/pull/30#issuecomment-1149755309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD77KKJKBJ6LNZJUWQWDPNLVOB2O5ANCNFSM5PXIA46Q. You are receiving this because you authored the thread.

javierdlr commented 2 years ago

Yes, you're right I get some GRID errors :-/ so can't build Oddysey. I imagine to "fix" this problem Odyssey should be updated first to 1.24 code?

andresiegel commented 2 years ago

In order to fix the problem, try to undo your cmake.txt changes.

On 10. Jun 2022, at 09:21, Javier de las Rivas @.***> wrote:

Yes, you're right I get some GRID errors :-/ so can't build Oddysey. I imagine to "fix" this problem Odyssey should be updated first to 1.24 code?

— Reply to this email directly, view it on GitHub https://github.com/kas1e/Odyssey/pull/30#issuecomment-1152053274, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD77KKPHPR3JKYEFS5ZDRRDVOLUHVANCNFSM5PXIA46Q. You are receiving this because you authored the thread.

andresiegel commented 2 years ago

Yes, you're right I get some GRID errors :-/ so can't build Oddysey. I imagine to "fix" this problem Odyssey should be updated first to 1.24 code?

I committed some minor changes. Odyssey v1.23 fully compiles for me.

andresiegel commented 1 year ago

Put differently, remove this…

set(ENABLE_CSS_GRID_LAYOUT ON) set(ENABLE_CSS_SHAPES ON)

And see what happens.

On 10. Jun 2022, at 10:31, André Siegel @.***> wrote:

In order to fix the problem, try to undo your cmake.txt changes.

On 10. Jun 2022, at 09:21, Javier de las Rivas @. @.>> wrote:

Yes, you're right I get some GRID errors :-/ so can't build Oddysey. I imagine to "fix" this problem Odyssey should be updated first to 1.24 code?

— Reply to this email directly, view it on GitHub https://github.com/kas1e/Odyssey/pull/30#issuecomment-1152053274, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD77KKPHPR3JKYEFS5ZDRRDVOLUHVANCNFSM5PXIA46Q. You are receiving this because you authored the thread.