search

kaschioudi / ojs3-markup

markup plugin for OJS3
8 stars 15 forks source link

Untranslated locale key "submission.copyrightStatement" appears in OTS XML #52

Closed asmecher closed 6 years ago

asmecher commented 6 years ago

The untranslated key submission.copyrightStatement appears in OTS XML. It appears to be injected by the OTS plugin. The respective locale file needs to be loaded before the key is used.

kaschioudi commented 6 years ago

@asmecher : not sure how plugins manually load their locale file. I know of AppLocale::requireComponents which take LOCALE_COMPONENT_... constants

is it $this->addLocaleData(); in plugin's register() ?

asmecher commented 6 years ago

That locale key is in the pkp-lib locale files, not the plugin locale files, so you'd need to load the right locale file with

AppLocale::requireComponents(LOCALE_COMPONENT_PKP_SUBMISSION);
kaschioudi commented 6 years ago

My bad. I understood the local key was coming from the plugin.

asmecher commented 6 years ago

@kaschioudi, I ran into this again today -- don't forget to make sure everything in ojs-stable-3_1_0 also gets forward-ported to master!

kaschioudi commented 6 years ago

@asmecher : @axfelix and I have been waiting for you OK to merge ojs-stable-3_1_0 into master. Let me know if I can go ahead with the merge.

asmecher commented 6 years ago

Is there a pull request open for this? I didn't know you were waiting for me.