kasecato / vscode-intellij-idea-keybindings

Port of IntelliJ IDEA key bindings for VS Code.
https://marketplace.visualstudio.com/items?itemName=k--kato.intellij-idea-keybindings
MIT License
819 stars 136 forks source link

Ctrl+D doesn't work for duplicate selection #161

Closed alexandrtovmach closed 4 years ago

alexandrtovmach commented 4 years ago

Environment

Steps to reproduce

  1. Select multiline code
  2. Ctrl+D

Expected result

Multiline code duplicating below selected code

Actual result

Error message

command 'editor.action.duplicateSelection' not found

image

I think it somehow related to https://github.com/kasecato/vscode-intellij-idea-keybindings/commit/1ac777be9c34168379f70145543eeecb1ae9fd24

kasecato commented 4 years ago

Hi @alexandrtovmach , Thanks for your detailed report. The keybindings will release in October milestone. If it's not released even after Oct 31, I will revert it. Thanks

Hoffs commented 4 years ago

Wouldn't it make more sense to release it after Oct31 (or after october release in general) as it is more likely that most users of the extension aren't running insider builds and with the current approach the command will be broken for 8+ days for majority (my guess) of users.

kasecato commented 4 years ago

@Hoffs @alexandrtovmach I reverted it.

alexandrtovmach commented 4 years ago

@kasecato Thank you