search

kasecato / vscode-intellij-idea-keybindings

Port of IntelliJ IDEA key bindings for VS Code.
https://marketplace.visualstudio.com/items?itemName=k--kato.intellij-idea-keybindings
MIT License
819 stars 136 forks source link

Add basic keymaps to Importer #195

Closed kasecato closed 3 years ago

kasecato commented 3 years ago

See https://github.com/kasecato/vscode-intellij-idea-keybindings/issues/120#issuecomment-766296058

ijoseph commented 3 years ago

Thanks for your diligence on this :)

ijoseph commented 3 years ago

From the other thread

some basic key mappings like cut and paste were missing.

but, I do see cut and paste in my Emacs copy.xml file: 

<keymap version="1" name="Emacs copy" parent="Emacs">
  <action id="$Copy">
    <keyboard-shortcut first-keystroke="alt c" />
    <keyboard-shortcut first-keystroke="escape" second-keystroke="w" />
    <keyboard-shortcut first-keystroke="meta c" />
  </action>
  <action id="$Cut">
    <keyboard-shortcut first-keystroke="shift delete" />
    <keyboard-shortcut first-keystroke="meta x" />
  </action>
  <action id="$Paste">
    <keyboard-shortcut first-keystroke="alt p" />
    <keyboard-shortcut first-keystroke="ctrl y" />
    <keyboard-shortcut first-keystroke="meta v" />
  </action>
  <action id="$Redo">
    <keyboard-shortcut first-keystroke="shift ctrl z" />
    <keyboard-shortcut first-keystroke="shift alt minus" />
    <keyboard-shortcut first-keystroke="shift meta z" />
  </action>
...

perhaps you were speaking generally, though.

the default emacs bindings will not be reflected because of it not exported in xml.

Hm, I couldn't find any that were not reflected in the XML, upon looking. For example, the alt-f emacs shortcut was here: 

...
  <action id="EditorNextWord">
    <keyboard-shortcut first-keystroke="alt f" />
    <keyboard-shortcut first-keystroke="escape" second-keystroke="ctrl f" />
    <keyboard-shortcut first-keystroke="alt right" />
  </action>
  <action id="EditorNextWordWithSelection">
    <keyboard-shortcut first-keystroke="shift ctrl right" />
    <keyboard-shortcut first-keystroke="shift alt right" />
  </action>
...

here is another copy (of just the XML file this time).

kasecato commented 3 years ago

That's true. I added EditorNextWord, EditorNextWordWithSelection and more. Thank you. https://github.com/kasecato/vscode-intellij-idea-keybindings/pull/196/files

ijoseph commented 3 years ago

Oh, I see, you meant missing from your mapping file ActionIdCommandMapping.json. Gotcha. Ok, I'll try again (when 1.0.1 is released)!

kasecato commented 3 years ago

@ijoseph I just released v1.0.1. Thank you for your help. Please check it.