kasecato / vscode-intellij-idea-keybindings

Port of IntelliJ IDEA key bindings for VS Code.
https://marketplace.visualstudio.com/items?itemName=k--kato.intellij-idea-keybindings
MIT License
819 stars 136 forks source link

[bug report] revertselectedRanges should work outside of diffEditor #205

Closed xc1427 closed 3 years ago

xc1427 commented 3 years ago

In files package-with-comment.json, we now have

{
                "key": "ctrl+alt+z",
                "mac": "cmd+alt+z",
                "command": "git.revertSelectedRanges",
                "when": "isInDiffEditor",
                "intellij": "Rollback Lines"
            },

which specifies isInDiffEditor, but why not a more general case editorTextFocus.

kasecato commented 3 years ago

note

kasecato commented 3 years ago

Hi, @xc1427
I'll fix it. I went with the official key bindings, but I was wrong. And I'll pull request it to VSCode repo, too.

Thank you.

kasecato commented 3 years ago

@xc1427 I released it on v1.3.0. Please check it

kasecato commented 3 years ago

Seems like VSCode doesn't change the default keymap, anymore.