search

kasecato / vscode-intellij-idea-keybindings

Port of IntelliJ IDEA key bindings for VS Code.
https://marketplace.visualstudio.com/items?itemName=k--kato.intellij-idea-keybindings
MIT License
817 stars 135 forks source link

Go to Symbol in Editor... - Ctrl+F12 keybinding is not working anymore in markdown files #211

Closed agostonbarna closed 3 years ago

agostonbarna commented 3 years ago

The Ctrl+F12 keybinding used to trigger the Go to Symbol in Editor.. command for markdown headers image but not anymore.

As a workaround I removed the editorHasDefinitionProvider condition from the when criteria of the workbench.action.gotoSymbol keybinding:

{
  "key": "ctrl+f12",
  "command": "workbench.action.gotoSymbol",
  "when": "editorTextFocus"
},
{
  "key": "ctrl+f12",
  "command": "-workbench.action.gotoSymbol",
  "when": "editorHasDefinitionProvider && editorTextFocus"
}

But it would be nice if this would be the default in the extension.

Note that the default Go to Symbol in Editor... keybinding doesn't have a when condition at all: image

IntelliJ IDEA Keybindings version: v1.3.0 VS Code version: 1.53.2 OS: Linux

agostonbarna commented 3 years ago

Wow, thanks for the quick fix @kasecato :+1:

kasecato commented 3 years ago

@agostonbarna Just released v1.4.0. Please check it

agostonbarna commented 3 years ago

@kasecato: thanks, after upgrading to v1.4.0 I can confirm that the Ctrl+F12 keybinding is now working fine without my workaround :1st_place_medal: (I just had to upgrade VS Code to 1.54 first)