Fix a bug which will cause failed

kasecato / vscode-intellij-idea-keybindings

Port of IntelliJ IDEA key bindings for VS Code.

https://marketplace.visualstudio.com/items?itemName=k--kato.intellij-idea-keybindings

MIT License

813 stars 135 forks source link

Fix a bug which will cause failed #293

Closed ShellWen closed 11 months ago

ShellWen commented 1 year ago

Use Array.forEach instead of for-in to avoid iterate over internal properties of keystorkeElements. It will cause a crash because keystrokeIndex will be 'distinct' instead of real index, and it will make keyboardShortcutElement to be a function. firstKeystrokeAttr & secondKeystrokeAttr will be undefined.

ShellWen commented 12 months ago

This PR hasn't been reviewed for a long time.

kasecato commented 11 months ago

@ShellWen Thank you

kasecato commented 11 months ago

I released it on v1.5.10 now. Please check it