kasecato / vscode-intellij-idea-keybindings

Port of IntelliJ IDEA key bindings for VS Code.
https://marketplace.visualstudio.com/items?itemName=k--kato.intellij-idea-keybindings
MIT License
810 stars 135 forks source link

[BUG] "Show Next Change" is mapped instead of "Go to Next Change" #310

Closed rybak closed 8 months ago

rybak commented 9 months ago

Thank you for developing and maintaining this VS Code extension. It allows me to not have to remember two sets of shortcuts, which is great.

Bug description

This bug applies to "Show Next Change" and to "Show Previous Change". IntelliJ IDEA has a pair of shortcuts:

Next Change ctrl+alt+shift+

Previous Change ctrl+alt+shift+

Both of these immediately jump to the corresponding place in the file. They correspond to VS Code's commands workbench.action.editor.nextChange and workbench.action.editor.previousChange. Corresponding native shortcuts:

image

But the extension IntelliJ IDEA Keybindings (v1.5.10) maps the IntelliJ IDEA's shortcuts to VS Code's "Show Next Change" (editor.action.dirtydiff.next) and "Show Previous Change" (editor.action.dirtydiff.previous) instead.

Expected shortcuts

image

(screenshot was made by configuring the shortcuts manually by replacing both System and the extension's shortcuts)

Actual shortcuts

image

As far as I can tell, there is no way to jump/navigate to changed place in the code, once it is shown/peeked by these shortcuts. For example, when IntelliJ"s shortcut ctrl+B (editor.action.goToDeclaration) is used in VS Code, then the peeked locations can be navigated with VS Code's F12 and with also with arrow keys.

kasecato commented 9 months ago

@rybak Thank you so much your details, I just released v1.5.11, check it please

rybak commented 9 months ago

Works for me in 1.5.11 without user overrides. Thank you!

image