kasecato / vscode-intellij-idea-keybindings

Port of IntelliJ IDEA key bindings for VS Code.
https://marketplace.visualstudio.com/items?itemName=k--kato.intellij-idea-keybindings
MIT License
810 stars 135 forks source link

Question on hotkey Shift-Esc #354

Closed mondwan closed 2 months ago

mondwan commented 2 months ago

In #349, it fixed the hotkey shift+escape to Hide Active Tool Window. So, it can hide the terminal as expected. But, how can I "show" the terminal again?

Before the fix, I can "Shift+Escape" to hide the terminal, and pressing the same hotkey for getting the terminal back. After updating this plugin to latest version, however, I cannot do so.

Currently, I rolled back the key binding version due to this reason. Just wondering is there any way for configuring this plugin / vscode so that it can "show" the terminal again by pressing the same hotkey?

kasecato commented 2 months ago

This change emulates IntelliJ's shortcuts We need to use alt+f12 instead of shift+esc for the toggle terminal Please see https://github.com/kasecato/vscode-intellij-idea-keybindings/issues/103

Skaldebane commented 2 months ago

@kasecato While it's more consistent with IntelliJ, it's less convenient. Now every time I use the new keybinding, I get a new terminal, which sucks.

Since the previous shift + esc keybinding is now free, is it possible to keep the old default behavior (New or last used terminal) under that keybinding?

mondwan commented 2 months ago

@kasecato Thanks for the confirmations. But I agree with @Skaldebane point of view.

Any suggestion on how can we customise the configuration so that we can have the original behaviour if we want to?

Thanks for your time

kasecato commented 2 months ago

@Skaldebane @mondwan We can add the below keybinding to the keybindings.json See https://code.visualstudio.com/docs/getstarted/keybindings#_advanced-customization

[
    {
        "key": "shift+escape",
        "mac": "shift+escape",
        "command": "workbench.action.terminal.toggleTerminal",
        "intellij": "Hide active or last active window (Terminal)"
    }
]
Skaldebane commented 2 months ago

@kasecato Thanks a lot! That works!

wenduof commented 1 month ago

Solved. Thans!