Closed ppisar closed 6 years ago
Hmmm, right. What do you make of this, @jonassmedegaard ? I introduced the patch that did the opposite, and I tend to think that there is a difference between distributions, where the path to the interpreter is fixed and known, and non-distro users, where the opposite may be true. I'm therefore inclined to say that distros should make this patch.
I agree with you, Kjetil: for CPAN it is undefined where perl is, so it makes better sense to then resolve that at runtime and rely on users' environment setup. Distributions know where perl is - and may want to avoid alternatively available perls, as is nicely explained at https://lists.debian.org/20120731144417.GA1281@caimano.fdc.rm-rf.it
OK, thanks, @jonassmedegaard ! Is it OK with you, @ppisar ? Are you looking into packaging Attean for Fedora? (That would be wonderful, BTW)
I tend to agree with @kjetilk and @jonassmedegaard. I think the user experience for somebody installing through CPAN is better using env
, and each distribution has the ability to patch to match their location and packaging guidelines.
I'm fine with it. Yes, it will be packaged https://bugzilla.redhat.com/show_bug.cgi?id=1531582.
Great stuff!
Also note that we are hanging out on irc://irc.perl.org/#perlrdf if you need to chat. :-)
Using "/usr/bin/env" in shebangs is not welcomed by software distributors (https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Shebang_lines, https://www.debian.org/doc/packaging-manuals/python-policy/ch-python.html#s-interpreter_loc).
This pull request fixes by utilizing ExtUtils::MakeMaker feature that rewrites the paths to perl used at build time.
I know that different people have different opinions on this issue but if you merged this patch, it would saved some people from maintaining a special patch.