search

kasei / attean

A Perl Semantic Web Framework
19 stars 10 forks source link

More coercions #144

Closed kjetilk closed 4 years ago

kjetilk commented 4 years ago

This adds more coercions, mainly from Trine. It also removes the Namespace coercion, which didn't belong here and shouldn't have worked. I have added that to Types::Namespace instead, released in 1.10.

There are a two others that might be nice to have, but I'm not sure about them, so I'll add issues about them.

kjetilk commented 4 years ago

Actually, I just got confused...: How could this run without adding a dependency on Types::URI? But it does pass...

kasei commented 4 years ago

@kjetilk is this good to merge, or did you want to figure out the Types::URI dependency?

kjetilk commented 4 years ago

Lets see...

Right, so it works because URI::NamespaceMap depends on Types::URI already. URI::NamespaceMap also depends on the Path and Uuid types, which I removed from my initial patch to reduce the dependency chain.

So, I don't know, should we just go for the full dependency chain here, or should I attempt to reduce the dep chain in URI::NamespaceMap?

kjetilk commented 4 years ago

argh, rebase is just scary, I tried, and things seem to have been messed up...

kjetilk commented 4 years ago

Superseded by #148 .