search

kasei / perlrdf

Deprecated in favor of the Attean package
26 stars 25 forks source link

Change Serializer to work fine with UTF-8 outputs. #122

Closed renatocron closed 7 years ago

renatocron commented 9 years ago

I had some problems with double-encoding on RDFXML and missing encoding on RDFJSON, and then, after trying a lot of things, that is what I've find.

N-Tripes are/were fine because chars is represented in \x{xx}

Please consider testing it before update CPAN.

Bump version is also needled.

kasei commented 9 years ago

As I mentioned on irc, the utf8 encoding issues you're having are due to poor documentation/method names. The serialize_*_to_string methods return UTF-8 encoded scalars (bytes). If you UTF-8 decode the results from serialize_model_to_string, you should get a valid unicode string.

I thought we had added documentation to clarify this issue at some point in the past, but can't find anything in the source. Now that you know the expected (though non-obvious) results from the serialization methods, would you find such a documentation change acceptable, or do you think there are still encoding problems?

kasei commented 7 years ago

Closing this as I believe it is a non-issue and there wasn't any followup after the initial PR.