search

kasei / perlrdf

Deprecated in favor of the Attean package
26 stars 25 forks source link

API inconsistent between RDF::Trine::Store::Memory and RDF::Trine::St… #150

Closed minusdavid closed 7 years ago

minusdavid commented 7 years ago

As per issue #149 on Github, RDF::Trine::Store::SPARQL doesn't implement the remove_statements() function interface in accordance with the documentation or all the other RDF::Trine::Store::* modules. It takes ($statement,$context) parameters instead of ($subj,$pred,$ojb,$context) parameters.

This patch keeps this inconsistent behaviour so as to be backwards compatible, but also provides support for the interface referenced in the documentation and implemented by other storage backends.

This patch also includes unit tests to check both sets of parameters with and without context.

kasei commented 7 years ago

Thanks!

minusdavid commented 7 years ago

How often are new CPAN releases made? At the moment, I'm working around this issue in my code, but I'd like to plan ahead to just use the consistent API.

kasei commented 7 years ago

There's no predictable schedule, but a request like this will often give me enough of a push to get one out :) I've packaged up a beta version of it and will get a full release out when passing test results show up. Thanks!

minusdavid commented 7 years ago

Cheers @kasei! Thanks for that : )