search

kasemir / org.csstudio.display.builder

Update of org.csstudio.opibuilder.*
Eclipse Public License 1.0
2 stars 10 forks source link

No context menu on OPI opened as Standalone Window #434

Closed claudio-rosati closed 6 years ago

claudio-rosati commented 6 years ago

If you open a Standalone Window, you'll not be able to have the usual contextual menu, allowing to send the PV of a right-clicked widget to DataBrowser and other PV consumers.

If the OPI is, instead opened as a New Workbench Window or New Tab it works fine.

I understand that this is related to open an SWG menu from a pure JavaFX window, but is currently a serious issue.

CSSTUDIO-812.zip

kasemir commented 6 years ago

Don't use standalone windows. They were introduced by DLS for BOY to be pure Shell windows which are then managed via X windows commands, without support for paerspectives, save/restore, context menu, ..

I'll update the display builder to handle them just like 'new window', and in Phoebus the issue is obsolete because single-content windows visually look like 'standalone'.

willrogers commented 6 years ago

Sorry, my comment was referring to BOY.

kasemir commented 6 years ago

'Standalone' display builder windows are now detached RCP parts. So they have no toolbar, i.e. they have the desired minimalistic look, but they're still integrated with context menu, perspective save/restore is enabled, and ScriptUtil.closeDisplay() works on them.

claudio-rosati commented 6 years ago

Thank you Kay. I'm rebuilding and the test it. I'll close the issue.

claudio-rosati commented 6 years ago

It works... but... the window is not correctly sized. The new Tab bar height should be added to the overall windows height, otherwise scrollbars appear.

kasemir commented 6 years ago

Try to determine the height of the tab that works for you on your computer right now, and put that into a pull request.

claudio-rosati commented 6 years ago

OK