Reload Display in editor mode should check whether the file is saved.

[claudio-rosati]

When in editor mode, and the current OPI is not saved (asterisk on the tab name), invoking the contextual menu's Reload Display will reload the original OPI file without notifying the user.

I should, instead, ask for:

• Aborting the operation;
• Saving the file first (this is useful when the current display seems needing a full refresh);
• Reverting to the saved content.

[kasemir]

OK, I'll add that.

[claudio-rosati]

Thank you

[kasemir]

Altogether, I see at least these scenarios

1. OK, revert to the saved content, abandon the in-memory changes
2. Cancel, want to keep the in-memory changes
3. Save under a different name for later use, then load the original file and edit that
4. Save under a different name, then edit that new file and leave the original file unchanged
5. Save the file and then reload, within the same editor, because I think the editor messed up
6. Save the file, close editor, then open in a new editor, because I think the editor messed up

5 and 6 are really for debugging the editor. We can't have preventive actions everywhere to work around bugs, need to instead identify and fix them. That still leaves at least 4 options, which would result in an unwieldy dialog. So I implemented 1 and 2. If the user cancels, the user can then do either 3 or 4. In essence, it's thus just like the "Do you really want to close" behaviour when closing a dirty editor.

[claudio-rosati]

I think it is reasonable. At the end what is important is to know that I'm about to clear my changes, and possibly abort it.