search

kasemir / org.csstudio.display.builder

Update of org.csstudio.opibuilder.*
Eclipse Public License 1.0
2 stars 10 forks source link

LED colour alway magenta in editor mode #492

Closed claudio-rosati closed 5 years ago

claudio-rosati commented 5 years ago

I was reported that in the last version of Display Builder LED and MultiLED widgets always shows the Magenta (invalid/unconnected) colour in edit mode, instead of the OFF/State-0 one. In runtime mode, instead, everything was fine.

screenshot 2019-01-29 at 10 15 49

The fix was easy (BaseLEDRepresentation:173). I've improved (I think at least) how LEDs (LED, MultiLed, BoolButton and ByteMonitor) are displayed in edit mode, showing all the colours:

screenshot 2019-01-29 at 10 15 06

Here and example of what a synoptic view looks like in edit mode after the change:

screenshot 2019-01-29 at 10 18 01
kasemir commented 5 years ago

Neat idea. Is there a problem when you have say N states but the widget size is smaller than N mixes, so the color bands have zero pixel widths?

claudio-rosati commented 5 years ago

@kasemir Yes, it works, as you can see in the following image, where the last 2 groups of LEDs have more states than pixels (along the diagonal).

screenshot 2019-01-30 at 12 26 53

kasemir commented 5 years ago

Great! Thanks for testing.