Refactor Models - Githubissues

kaseymccormick commented 9 years ago

[x] Methods should be small – 1-3 lines each, or maybe 4-5 lines if there is a loop in the method.
[ ] Follow DRY and SRP to the best of your ability.
[ ] If it can be done in the model, it probably should be. Then: If it can be done in the controller, it probably should be. Views should have as little Ruby in them as possible (but they will have all the HTML).
[x] Try to define as much business logic without needing to connect to the database as possible.
[x] A model should only have database connections to its corresponding table. If it needs to access another table (which is common, and that's okay/good), it should do so using a method from that table's corresponding model.
[x] How to get approval: Create a new Issue in your repository, called "Feedback for Refactoring" -> https://github.com/kaseymccormick/sinatra_project/issues/26. Post a link to that Issue in a help channel and mention Sumeet.

kaseymccormick commented 9 years ago

my views seem to have more ruby then needed/desired but as they are within loops I'm not sure how to make the system work by taking it out of the view. I've made as many method/class calls as possible in the router instead of the view. Will need some more work with a better understanding coding more loops on redo of pre-work.

kaseymccormick commented 9 years ago

Also need to take a look at the loops to verify dry and srp

kaseymccormick / sinatra_project

Refactor Models #27