Closed afedotov closed 1 year ago
Thanks for all these great PRs Andy! I don't think we've chatted before but please feel free to reach out on Discord to chat any time. Really appreciate the effort you're putting into this codebase!
Just have some spare time at these hard days. Great opportunity to learn something by solving real world problems and cubes :) We've chatted on Discord, I have another nickname there, about that class-validator issue.
Added
Full Screen
button.Wanted to be implemented using screenfull npm library. But due to ESM loader issues in
ts-node-dev
for now pure ESM modules can't be used even in client code. Althoughts-node
supports them viats-node/esm
loader,ts-node-dev
does not respect it.So for now just put
screenfull
library as vendor code right in the Cubedesk codebase.Fix 100vh height for mobile devices that does not respect dynamic toolbars. Just look at screenshots from iPad and Android phone:
More readings on topic:
Got rid of annoying text selection which popups when using timer on touch devices especially with bigger screens like iPad.
https://user-images.githubusercontent.com/4266693/224285521-a17d10a3-a8bd-4e81-9556-7b4f1aa2aff6.mp4