search

kashalls / external-dns-unifi-webhook

External-DNS Webhook to manage UniFi DNS Records
Apache License 2.0
93 stars 5 forks source link

Remove leading "\"" #11

Closed jimmy-ungerman closed 3 months ago

jimmy-ungerman commented 3 months ago

The code change removes the "\"" as desired. Here's the new output of the records endpoint:

  {
    "dnsName": "k8s.cname-prom.porkboi.io",
    "targets": [
      "heritage=external-dns,external-dns/owner=default,external-dns/resource=ingress/monitoring/prometheus-kube-prometheus-prometheus"
    ],
    "recordType": "TXT",
    "setIdentifier": "6650be64b2b8464db0d16ad6"
  },

However, we're still getting the error:

 Skipping endpoint alertmanager.porkboi.io 0 IN CNAME 6650be64b2b8464db0d16ab2 porkboi.io [] because owner id does not match, found: \"\", required: \"default\""

Still think this is good to add though, makes the output look much cleaner.

kashalls commented 3 months ago

We actually tried removing the leading \", some test data from external-dns leads me to believe that this is required still. Is this working on your side?

jimmy-ungerman commented 3 months ago

The endpoint works, and records are getting created, however the txt lookup still fails. I was thinking this still makes the output look cleaner

buroa commented 3 months ago

This isn't needed and is wrong.. I'll have the changes out soon.