search

kashif / firedup

Clone of OpenAI's Spinning Up in PyTorch
MIT License
146 stars 25 forks source link

Update ppo.py #2

Closed ZachariahRosenberg closed 5 years ago

ZachariahRosenberg commented 5 years ago

removed beginning code from update fn. This is performed within the pi training loop

kashif commented 5 years ago

thanks @ZachariahRosenberg

So this piece of code you are right is somewhat repeated and perhaps should go into a helper. I do however need the pi_l_old before I do anything since the logger then uses this to print out the change for example DeltaLossPi=(pi_l_new - pi_l_old)

does that make sense?

ZachariahRosenberg commented 5 years ago

Fair - I didn't consider the logging.