search

kashiif / copy-urls-expert

Copy Urls Expert - Firefox Extension
https://addons.mozilla.org/firefox/addon/copy-urls-expert/
MIT License
23 stars 11 forks source link

Choose format from menus #14

Closed qoxxxx closed 7 years ago

qoxxxx commented 8 years ago

If I'm not mistaken, in order to switch format you have to go every time to the addon's option menu and then set the default format ?

It would be nice to have access to all defined formats from the right-click menu.

kashiif commented 8 years ago

I've been thinking on this.

One possible solution is have a separate menu item in context menu called "All formats". That means a menu structure as follows:

Copy Urls Expert 
     |----- ...
     |----- All Formats
               |----- Tabs in this window
               |            |----- html
               |            |----- forum
               |----- Tabs in all windows
               |            |----- html
               |            |----- forum
               |----- Tabs in this tag group
               |            |----- html
               |            |----- forum
               |----- Current Tab
                            |----- html
                            |----- forum

Where "html" and "forum" are the names of two styles defined (other than default format).

kashiif commented 8 years ago

The problem with above solution is it makes menu complicated.

The other solution that I have in my mind is to add a "Advanced Copy" menu item. When you click on it, a dialog pops up and it lets you select one of the defined formats and one of the options for what tabs to copy (active window, all windows, active tag group etc.). In the future I can add more customization options to this dialog.

To me, this seems simpler. Only the people interested in advanced copy, would use that menu and everything remain the same for a normal user.

What do you think? Or if you have any suggestion, I would like to hear it.

Gitoffthelawn commented 8 years ago

I like the idea of keeping it simple for day-to-day use, and then having advanced options for the unique cases.

qoxxxx commented 8 years ago

I was thinking of that kind of complicated tree, but I like the popup menu idea better actually.

atomGit commented 8 years ago

+1 for a context menu of available formats

for users that think this is too complex, you could copy with the default format and only expose the menu of all available formats with a hot-key when clicking the parent ("Tabs in ...") menu, however if this is how it get implemented, i would hope for an option to always show the formates menu by default (without having to press a hot-key)

Avierling commented 7 years ago

an alternative is have a Lite version

kashiif commented 7 years ago

The code has been pushed to ADVANCE_COPY branch. If anyone would like to test and provide feedback, I can provide xpi (that can be installed in nightly).

Keith94 commented 7 years ago

@kashiif Some feedback:

kashiif commented 7 years ago

@Keith94

If I assign Advanced Copy to toolbar button default action, it doesn't work.

This is now fixed in ADVANCE-COPY branch. With this, I have completed all items for the next release (v2.6.0). Feel free to create a new issue if you find anything.

Thank you for your valuable feedback.