search

kashiif / edit-bookmark-plus

Edit Bookmark Plus - Firefox Extension
Other
3 stars 3 forks source link

add support for tags #7

Closed wagle closed 8 years ago

wagle commented 9 years ago

remove some trailing whitespace add newline at end of defaults.js

wagle commented 9 years ago

mostly my tag support deleted some trailing whitespace in both your and my stuff my editor added a newline at the end of defaults.js

wagle commented 8 years ago

Any news on including some variant of this patch?

Anything I can do?

kashiif commented 8 years ago

I tried to get it working but it breaks one thing or another. Can't remember exactly but it it did not work as expected even when I tried to fix it

wagle commented 8 years ago

I can fix it if I knew what was wrong (Works For Me [tm]).

kashiif commented 8 years ago

Can't really recall from the top of my head. If you can remove the merge conflict, I can give it a try again and let you know the issues.

wagle commented 8 years ago

Only "problem" Isee right now with that is the unterminated line at the end of src/chrome/content/editbookmarkplus.js ?

wagle commented 8 years ago

Oh.. I think my git decided to trim trailing whitespace.

wagle commented 8 years ago

No, git complained and I ran dos2unix on everything.. You want to do that as a separate commt, or shall I, or should I remove it?

wagle commented 8 years ago

See new pull request.