search

kashike / limbo-config

Configuration files for @limbo-app.
0 stars 0 forks source link

Mark newly opened PR as wip #3

Closed ImMorpheus closed 4 years ago

ImMorpheus commented 6 years ago

The current situation is a bit messy.

A contributor needs to mark manually a PR by commenting ~wip or ~qa, but that's documented nowhere.

It would be good if limbo could mark a new PR as wip and posting a comment along the lines of "If you think this PR is ready, comment with ~qa"

EDIT: What I meant when I said documented was that a user has no way of knowing limbo's tricks when he's opening a PR.

ryantheleach commented 6 years ago

I'd be ok with this, but would rather it reply with the instructions, instead of assuming it's status.

liach commented 6 years ago

you are already able to mark it by starting the title with [wip]

liach commented 6 years ago

@ImMorpheus https://github.com/SpongePowered/limbo-config/blob/d098fa52d425e01db66ac740a8af2e5f00c2e990/include/github/apply.xml#L56-L64

phit commented 6 years ago

@liach which is also undocumented..

liach commented 6 years ago

@phit Where is the documentation? I never knew there was one.

phit commented 6 years ago

https://github.com/SpongePowered/limbo-config/wiki

but thats not what I meant, its more like how is a pr author gonna know about this. kashike is working on a automatic message for first time contributors telling them about the commands