kashipai / h2database

H2 Database for reference.
0 stars 0 forks source link

Missing JavaDoc and code enhancement #500

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
While I'm using the H2 Api, I will write here where JavaDoc is missing, 
incomplete. And some non-critical code enhancement.

Missing javadoc in constructor
http://code.google.com/p/h2database/source/browse/trunk/h2/src/main/org/h2/resul
t/Row.java?r=4965#30
/**
 * @param memory Memory usage, set Row.MEMORY_CALCULATE to compute when needed.
 */

Primitive type List<String> should be used instead of implementation
http://code.google.com/p/h2database/source/browse/trunk/h2/src/main/org/h2/comma
nd/ddl/CreateTableData.java?r=4965#78

Original issue reported on code.google.com by nico.de...@gmail.com on 19 Jul 2013 at 1:30

GoogleCodeExporter commented 9 years ago
We use ArrayList instead of List because concrete types are faster on Android.

Original comment by noelgrandin on 20 Jul 2013 at 2:26

GoogleCodeExporter commented 9 years ago
And you use for(int i=0;i<len;i++) also too. But in the documentation of 
Android it says that your choices is slower:
http://developer.android.com/training/articles/perf-tips.html#Myths

Original comment by nico.de...@gmail.com on 20 Jul 2013 at 11:40

GoogleCodeExporter commented 9 years ago
Thanks, but we'll stick with our choices for now.

Original comment by noelgrandin on 22 Jul 2013 at 8:48