Close tab is not properly handled

[GoogleCodeExporter]

Google Chrome version: 3.0.195.33
SDK + Eclipse Debugger version(s): Latest SVN
OS + version: Windows XP SP2

What steps will reproduce the problem?
1. Open browser on some page.
2. Start browser with debug port, open some other page.
3. Attach the debugger.
4. Close the page being debugged.

What is the expected result?
Debugger disconnects from the browser.

What happens instead?
Debugger continues to run as if nothing happened.

Please provide any additional information below. If possible, attach a
(reduced) test-case.
I provide a patch with desired behavior. I'm not a user of the debugger - we 
are trying to create 
our own debugger based on this code. Please introduce the closeTab protected 
method so we 
can override it if this behavior is as designed or the fix is not as simple as 
I thought.

Original issue reported on code.google.com by eostrouk...@gmail.com on 21 Nov 2009 at 7:11

Attachments:

• chrome-close-tab.patch

[GoogleCodeExporter]

Thanks for reporting.
You may want to take a look at the patch we are going to commit to SVN in a 
couple of
days:
http://codereview.chromium.org/436006

Together with fix in UI, it also changes the semantics of "disconnected" event 
in
DebugEventListener and unties it from connection to browser (see javadoc 
changes).
Hope it works for you.

I don't quite see why you might need a protected method. DebugTargetImpl was not
supposed to be subclassed.

Peter

Original comment by peter.ry...@gmail.com on 29 Nov 2009 at 9:44

[GoogleCodeExporter]

This issue is fixed in a current SVN.

Original comment by eostrouk...@gmail.com on 3 Dec 2009 at 3:41

[GoogleCodeExporter]

Original comment by peter.ry...@gmail.com on 11 Dec 2009 at 12:07

• Changed state: Fixed