JsVariableImpl#variableFqn not valid

[GoogleCodeExporter]

This would really be best posted as a question in a dev mailing list, but I 
don't think there is one for 
this project, is there?

In class JsVariableImpl, the field variableFqn appears to be intended as the 
fully qualified name. But 
in practice it's not set and calling getFullyQualifiedName() doesn't return the 
appropriate value.

It would be very useful if this returned an name that could be used in 
expressions to set the variable 
value. Was that the intent here and would you be likely to accept a patch that 
addressed this?

Original issue reported on code.google.com by dpodwall on 3 Mar 2010 at 3:05

[GoogleCodeExporter]

Hi dpodwall

There is a dedicated google group 
http://groups.google.com/group/chromedevtools-dev,
however you may need to subscribe first to be able to write there.

I guess getFullyQualifiedName really should provide fully qualified name. It 
may be
broken though.

Could you please rephrase it more like an issue?

Peter

Original comment by peter.ry...@gmail.com on 4 Mar 2010 at 1:00

[GoogleCodeExporter]

And yes, patches are welcome.

Peter

Original comment by peter.ry...@gmail.com on 4 Mar 2010 at 1:02

[GoogleCodeExporter]

I have no ability to edit the issue in order to rephrase it better. Feel free 
to close this one out and I could create a 
new one.

Original comment by dpodwall on 4 Mar 2010 at 2:46

[GoogleCodeExporter]

I just was thinking about "expected/actual results [and rationale]" form. I'm 
fine with 
having this in comments or you indeed could open an new issue; I'll close this 
one 
accordingly.

Peter

Original comment by peter.ry...@gmail.com on 4 Mar 2010 at 5:20

[GoogleCodeExporter]

OK, so attached a simple example. If a breakpoint is set on the second line of 
the click() function and you run to 
that point, and expand the "obj" variable, there will be a JsVariableImpl 
instance corresponding to obj.value. 
Calling getFullyQualifiedName() on that instance should return "obj.value", but 
it currently returns "null.value".

The rationale is that we'd like to use the fully qualified name in order to 
build JavaScript expressions that can 
update variable values in the debugger.

Original comment by dpodwall on 5 Mar 2010 at 5:11

Attachments:

• index.html

[GoogleCodeExporter]

Fixed in head r314

Original comment by peter.ry...@gmail.com on 9 Mar 2010 at 5:01

• Changed state: Fixed