Open alextud opened 6 years ago
That's a very good idea guys! Thanks a lot! 🍻 @Janglinator do you have time to review it?
Hi guys, thanks for your effort so far! I really appreciate it! 🤝👍
I reviewed the code and all seem good to me, but I face an issue while I'm trying to run the demo app. libraries seem to not include the Swifter lib you added through pods as I get a runtime error (dyld: Library not loaded: @rpath/Swifter.framework/Swifter
). Did you face anything similar?
I like this! I usually use Charles Proxy for this, but it can be a pain trying to get SSL working. This would avoid that issue altogether, and really help out our QA team
@kasketis we dropped swifter dependency and cocoapods. Will double check by buillding it in a clean environment. Thanks
This is looking really great guys! If you're daunted by the change requests, I can make them too. Just give me a thumbs up of when you're done testing, and I can start merging in and making the above changes.
Thanks so much for doing this! We certainly appreciate how much work has gone into it.
@Janglinator There is an issue with continuous integration, can you look into that. On our side we need to update Readme page. Will move at the end description and images about netfox for mac integration.
I added a pull request to @alextud's pull request repo (pull-request-ception!), so just waiting for him to get that pulled in, then CI should pass. The branch is already passing.
@Janglinator I've move Readme notes about netfox_mac app in the second part of file. Also I've added a short thank you mention for tapptitude team. Thanks
Hi, any news on this pull request being accepted ?
Let's get this merged in! Would you be able to patch up the merge conflicts?
@alextud The build failed, but that's because your commit doesn't support Swift 3.2.
I brought this up in PR #140, we might just drop Swift 3.2 support. So just wait for a response from @kasketis to see if you even need to make any changes.
@Janglinator as we already need to start support to Swift 4.2, "soon" 5.0 I thing that would not be bad drop support for 3.2, even because to always maintain and try to follow best that swift can support, unfortunately today for swift environment we do need to migrate as soon as possible.
We have created a netfox_mac app which can connect to all apps (iOS or mac) that are running in local network using bonjour discovery mechanism.
Basically an iOS app that wants to expose it's network data to other mac app for inspection should activate bonjour service using: NFX.sharedInstance().startServer()
After that netfox_mac app can connect using the same UI as in the mac app with some teaks.
We want to merge back all changes into netfox repo after code and most of the new features are stable.
How that's sound, is it doable ? Thanks