kasketis / netfox

A lightweight, one line setup, iOS / OSX network debugging library! 🦊
MIT License
3.68k stars 374 forks source link

Realtime updates #110

Open alextud opened 6 years ago

alextud commented 6 years ago

We have created a netfox_mac app which can connect to all apps (iOS or mac) that are running in local network using bonjour discovery mechanism.

Basically an iOS app that wants to expose it's network data to other mac app for inspection should activate bonjour service using: NFX.sharedInstance().startServer()

After that netfox_mac app can connect using the same UI as in the mac app with some teaks.

We want to merge back all changes into netfox repo after code and most of the new features are stable.

How that's sound, is it doable ? Thanks

screenshot 2018-02-09 16 51 12 screenshot 2018-02-09 16 51 30

kasketis commented 6 years ago

That's a very good idea guys! Thanks a lot! 🍻 @Janglinator do you have time to review it?

kasketis commented 6 years ago

Hi guys, thanks for your effort so far! I really appreciate it! 🤝👍 I reviewed the code and all seem good to me, but I face an issue while I'm trying to run the demo app. libraries seem to not include the Swifter lib you added through pods as I get a runtime error (dyld: Library not loaded: @rpath/Swifter.framework/Swifter). Did you face anything similar?

Janglinator commented 6 years ago

I like this! I usually use Charles Proxy for this, but it can be a pain trying to get SSL working. This would avoid that issue altogether, and really help out our QA team

alextud commented 6 years ago

@kasketis we dropped swifter dependency and cocoapods. Will double check by buillding it in a clean environment. Thanks

Janglinator commented 6 years ago

This is looking really great guys! If you're daunted by the change requests, I can make them too. Just give me a thumbs up of when you're done testing, and I can start merging in and making the above changes.

Thanks so much for doing this! We certainly appreciate how much work has gone into it.

alextud commented 6 years ago

@Janglinator There is an issue with continuous integration, can you look into that. On our side we need to update Readme page. Will move at the end description and images about netfox for mac integration.

Janglinator commented 6 years ago

I added a pull request to @alextud's pull request repo (pull-request-ception!), so just waiting for him to get that pulled in, then CI should pass. The branch is already passing.

alextud commented 6 years ago

@Janglinator I've move Readme notes about netfox_mac app in the second part of file. Also I've added a short thank you mention for tapptitude team. Thanks

alextud commented 6 years ago

Hi, any news on this pull request being accepted ?

Janglinator commented 6 years ago

Let's get this merged in! Would you be able to patch up the merge conflicts?

Janglinator commented 6 years ago

@alextud The build failed, but that's because your commit doesn't support Swift 3.2.

I brought this up in PR #140, we might just drop Swift 3.2 support. So just wait for a response from @kasketis to see if you even need to make any changes.

felipeflorencio commented 6 years ago

@Janglinator as we already need to start support to Swift 4.2, "soon" 5.0 I thing that would not be bad drop support for 3.2, even because to always maintain and try to follow best that swift can support, unfortunately today for swift environment we do need to migrate as soon as possible.