kasketis / netfox

A lightweight, one line setup, iOS / OSX network debugging library! 🦊
MIT License
3.68k stars 373 forks source link

Xcode 10 and Swift 4.2 #142

Closed CavalcanteLeo closed 2 years ago

kasketis commented 6 years ago

Without a description nobody can help you

CavalcanteLeo commented 6 years ago

Netfox doesn't work on xcode 10 and swift 4.2 @kasketis

Janglinator commented 6 years ago

What version? And "doesn't work" as in doesn't build, or no requests are logged?

CavalcanteLeo commented 6 years ago

version 1.12.1

My project is in objective-c, and i can't compile it anymore, some properties has changed the name, and th module can't find the header

I will send some screenshot in a bit

CavalcanteLeo commented 6 years ago
captura de tela 2018-09-21 as 18 28 00 captura de tela 2018-09-21 as 18 31 49
Janglinator commented 6 years ago

Hmm I'll take a look. What does your podfile look like? Do you do any post-install settings?

CavalcanteLeo commented 6 years ago
platform :ios, '10.0'
use_frameworks!
inhibit_all_warnings!

target 'Super Comics' do
    use_frameworks!

    pod 'Firebase/Core'
    pod 'Firebase/Messaging'
    pod 'Firebase/DynamicLinks'
    pod 'Fabric'
    pod 'Crashlytics'
    pod 'FBSDKCoreKit'
    pod 'FBSDKShareKit'
    pod 'FBSDKLoginKit'
    pod 'AccountKit'
    pod 'IGListKit'
    pod 'Texture'
    pod 'AFNetworking'
    pod 'AFNetworkActivityLogger'
    pod 'Material'
    pod 'JWT'
    pod 'IQKeyboardManager'
    pod 'Hero'
    pod 'SimpleKeychain'
    pod 'PINRemoteImage', '= 3.0.0-beta.13'
    pod "SwipeTransition"
    pod 'SwipeTransitionAutoSwipeToDismiss'
    pod 'GRKAnalytics' #analytics
    pod 'GoogleAnalytics'
    pod 'FSPagerView' #image pager gallery banner
    pod 'FCFileManager' # file management
    pod 'DeepLinkKit' #deep link
    pod 'Appirater' #rate on app store
    pod 'libPhoneNumber-iOS' # phone format
    pod 'netfox'

    target 'Super Comics Tests' do
        inherit! :search_paths
        pod 'Specta'
        pod 'Expecta'
        pod 'OCMock'
    end

    target 'Super Comics UITests' do
        inherit! :search_paths
    end

    post_install do |installer|
        installer.pods_project.targets.each do |target|
            target.build_configurations.each do |config|
                 config.build_settings['SWIFT_VERSION'] = '4.2'
                config.build_settings['GCC_WARN_INHIBIT_ALL_WARNINGS'] = 'YES'
            end
        end
    end
end
Janglinator commented 6 years ago

Sounds good, thanks for the feedback. I'll dig into this as soon as I get a chance.

CavalcanteLeo commented 6 years ago

Thank u

felipeflorencio commented 6 years ago

I don't know about the hole project or something like, but one thing, try to use swift 4.0. You will not miss anything for now and will build, as the library still use swift 4, try go to "Build Settings" and look for "Swift Language Version", set for Swift 4, as the error's are not that clear, try to set this to your app target if not set as swift 4. You can even do better, set this to the specific pod framework if not work, because doing this you will be able to get back working and discover which library is not building anymore on swift 4.

Let me know if help for now at least get back to work

hardikdevios commented 6 years ago

Any Update Guys ?

Janglinator commented 6 years ago

Wow, I'm so sorry guys. I merged in #140 and totally forgot to produce a new release. Pushing now

Janglinator commented 6 years ago

@CavalcanteLeo Would you be able to try out release 1.13.0 for me?

danielgomezrico commented 6 years ago

I tried 1.13.0 with swift 4 and Im getting:

/.../Pods/netfox/netfox/iOS/NFXDetailsController_iOS.swift:322:50: 'ActivityType' is not a member type of 'UIActivity'

screen shot 2018-11-07 at 12 38 11 pm

vGubriienko commented 2 years ago

Thanks for your report! Currently we can't reproduce the issue and close it. You could reopen it anytime if you still can reproduce it.