search

kasketis / netfox

A lightweight, one line setup, iOS / OSX network debugging library! 🦊
MIT License
3.67k stars 374 forks source link

Fix for issue #179: netfox can't be dismissed after navigate to a call #180

Closed HenriquePer5 closed 4 years ago

HenriquePer5 commented 4 years ago

The PR #172 solved an issue where presented was not false when the new iOS 13 semi modal is closed by scrolling, but unfortunately it created another issue. The Netfox can't be dismissed after navigate to a call, and then get back, described on issue #179. With this approach i believe the two issues will be resolved.

What do you guys think?

ZoRdAK commented 4 years ago

Haha, Same problem here, I did a correction too, but this one is great.

felipeflorencio commented 4 years ago

Not clear if removing that method is fixing, can you *(or more people) make sure that this si not breaking like the normal navigation that "was working" like, for iOS 12 or lower, for iOS.

Just a check that is not breaking for the "normal environment"

grzegorzprzybyla-silvair commented 4 years ago

Not clear if removing that method is fixing, can you *(or more people) make sure that this si not breaking like the normal navigation that "was working" like, for iOS 12 or lower, for iOS.

Just a check that is not breaking for the "normal environment"

I've check, and it's working on iOS 12