search

kaskr / TMB_contrib_R

9 stars 6 forks source link

Small changes to Optimizer #3

Closed colemonnahan closed 6 years ago

colemonnahan commented 6 years ago

I turned off trace by default. It's weird to have it be TRUE by default, when nlminb is expecting an integer (how often to print trace), so this gets evaluated to 1. I propose setting it to 0 to cleanup console output by default.

I also added a named element max_gradient which can be convenient to quickly check.

James-Thorson commented 6 years ago

Feel free to push the change, makes sense to me!

On Jan 3, 2018 1:17 PM, "Cole Monnahan" notifications@github.com wrote:

I turned off trace by default. It's weird to have it be TRUE by default, when nlminb is expecting an integer (how often to print trace), so this gets evaluated to 1. I propose setting it to 0 to cleanup console output by default.

I also added a named element max_gradient which can be convenient to quickly check.

You can view, comment on, or merge this pull request online at:

https://github.com/kaskr/TMB_contrib_R/pull/3 Commit Summary

  • Turn off trace by default in Optimizer
  • Add mgc to output of Optimizer

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/kaskr/TMB_contrib_R/pull/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AHnqTTWSTPs87h0r2QcB02Gxehp4Hyssks5tG-5rgaJpZM4RSRTd .

colemonnahan commented 6 years ago

I don't have write access so someone has to merge it for me.