kasnerz / letax

MIT License
1 stars 0 forks source link

Dockerization #57

Open kasnerz opened 1 year ago

amrit2611 commented 1 year ago

I would love to contribute on this. If I create a proper Dockerfile for this app and also upload it to Docker Hub. would that solve your issue?

kasnerz commented 1 year ago

@amrit2611 Sure, go ahead please! I can review your contribution once you add a pull request.

Keep in mind is that there are some required libraries apart from the Python packages: libimage-exiftool-perl + libheif for processing HEIC files and ffmpeg for processing videos. (I am not sure that is a complete list - should be tested.)

I apologize for the missing documentation and very bare Github issues, so far everything worked rather as TODO notes for myself 😅 I plan to make it better in the future.

(And a small disclaimer: I have actually never dockerized any app, I just know the point of it and I thought I would be a good idea 😇 )

amrit2611 commented 1 year ago

@amrit2611 Sure, go ahead please! I can review your contribution once you add a pull request.

Keep in mind is that there are some required libraries apart from the Python packages: libimage-exiftool-perl + libheif for processing HEIC files and ffmpeg for processing videos. (I am not sure that is a complete list - should be tested.)

I apologize for the missing documentation and very bare Github issues, so far everything worked rather as TODO notes for myself 😅 I plan to make it better in the future.

(And a small disclaimer: I have actually never dockerized any app, I just know the point of it and I thought I would be a good idea 😇 )

Got it have some current commitments will start work on this very soon.

kasnerz commented 11 months ago

@amrit2611 Hey, just checking if you made any progress regarding this?