search

kaspanet / kaspad

Kaspad was the reference full node Kaspa implementation written in Go (golang), now rewritten in Rust: https://github.com/kaspanet/rusty-kaspa
ISC License
447 stars 228 forks source link

Anti-spam measurements against dust attack #2223

Closed someone235 closed 11 months ago

codecov[bot] commented 11 months ago

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (bd14202) 58.88% compared to head (d323dbf) 58.81%.

:exclamation: Current head d323dbf differs from pull request most recent head 0871a3a. Consider uploading reports for the commit 0871a3a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2223 +/- ## ========================================== - Coverage 58.88% 58.81% -0.07% ========================================== Files 679 679 Lines 33122 33192 +70 ========================================== + Hits 19504 19523 +19 - Misses 10778 10822 +44 - Partials 2840 2847 +7 ``` | [Files](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet) | Coverage Δ | | |---|---|---| | [domain/miningmanager/mempool/error.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-ZG9tYWluL21pbmluZ21hbmFnZXIvbWVtcG9vbC9lcnJvci5nbw==) | `44.00% <ø> (ø)` | | | [...manager/mempool/validate\_and\_insert\_transaction.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-ZG9tYWluL21pbmluZ21hbmFnZXIvbWVtcG9vbC92YWxpZGF0ZV9hbmRfaW5zZXJ0X3RyYW5zYWN0aW9uLmdv) | `61.29% <ø> (ø)` | | | [version/version.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-dmVyc2lvbi92ZXJzaW9uLmdv) | `41.66% <ø> (ø)` | | | [cmd/kaspawallet/create\_unsigned\_tx.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-Y21kL2thc3Bhd2FsbGV0L2NyZWF0ZV91bnNpZ25lZF90eC5nbw==) | `0.00% <0.00%> (ø)` | | | [cmd/kaspawallet/send.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-Y21kL2thc3Bhd2FsbGV0L3NlbmQuZ28=) | `0.00% <0.00%> (ø)` | | | [...main/miningmanager/mempool/validate\_transaction.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-ZG9tYWluL21pbmluZ21hbmFnZXIvbWVtcG9vbC92YWxpZGF0ZV90cmFuc2FjdGlvbi5nbw==) | `60.00% <66.66%> (+1.93%)` | :arrow_up: | | [cmd/kaspawallet/config.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-Y21kL2thc3Bhd2FsbGV0L2NvbmZpZy5nbw==) | `0.00% <0.00%> (ø)` | | | [cmd/kaspawallet/utils/format\_kas.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-Y21kL2thc3Bhd2FsbGV0L3V0aWxzL2Zvcm1hdF9rYXMuZ28=) | `67.85% <82.60%> (+67.85%)` | :arrow_up: | | [domain/miningmanager/mempool/mempool.go](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet#diff-ZG9tYWluL21pbmluZ21hbmFnZXIvbWVtcG9vbC9tZW1wb29sLmdv) | `59.81% <22.85%> (-18.27%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/kaspanet/kaspad/pull/2223/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kaspanet)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

michaelsutton commented 11 months ago

Since this patch was widely accepted by the mining community (anti-spam-patch) we merge it directly to master and will add a tag v0.12.14 + a formal release in order to effectively make it a well known and consolidated version.

The patch introduces temporary tx relay rules and a local build block template strategy which avoids mining spam/dust txs. This is not a consensus rule change.

Note: the patch was not merged to the dev branch