kaspanet / rusty-kaspa

Kaspa full-node reference implementation and related libraries in the Rust programming language
ISC License
482 stars 153 forks source link

Wallet "remove account" functionality #258

Open aspect opened 1 year ago

aspect commented 1 year ago

It is currently not possible to remove private keys or accounts from the wallet.

Implement generic account removal as well as BIP44 account removal (backed by fund withdrawal, as it is not possible to remove BIP44 accounts until they are empty)

coderofstuff commented 1 year ago

Is there a "hide" functionality too or is this related to it?

The use case I'm thinking of is: As a user that already used an address, I don't want to use it anymore and I don't want to keep seeing it.

aspect commented 1 year ago

This issue specifically relates to account and private key removal from the wallet storage.

Address chains belong to accounts, where you can have for example bip32 or keypair account. Keypair holds a single address. However, a bip32 account holds a derivation chain. We've taken core Kaspa-wallet approach for derivation management, where a new address can be created manually on user request. This will "hide" the previous address. ("details" cmd can then be used to see all account addresses).