search

kaspanet / rusty-kaspa

Kaspa full-node and related libraries in the Rust programming language. This is a stable version at the initial rollout phases.
ISC License
376 stars 119 forks source link

Lock wasm-bindgen version due to upstream compatibility issues #315

Closed aspect closed 7 months ago

aspect commented 7 months ago

Upstream wasm-bindgen developers have added TryFrom<JsValue> for all wasm-bindgen ABI-bound Rust structs (https://github.com/rustwasm/wasm-bindgen/pull/3554) which came in with the 0.2.88 update and broke all our TryFrom<JsValue> conversion implementations. This PR freezes wasm-bindgen to the last viable version 0.2.87 until a solution is determined (whether upstream will consider reverting or we decide to create different traits for handling ABI object conversions). In the meantime, I have filed an issue https://github.com/rustwasm/wasm-bindgen/issues/3685

Updating Cargo.lock can result in the patch version update for wasm-bindgen, resulting in broken builds. This PR prevents this from happening.

(This PR also updates few dependency versions and removes Cargo.lock that seems to have been accidentally committed in the kaspa-addresses crate folder)