Remove File Descriptor init on Windows

kaspanet / rusty-kaspa

Kaspa full-node and related libraries in the Rust programming language. This is a stable version at the initial rollout phases.

ISC License

371 stars 118 forks source link

Remove File Descriptor init on Windows #344

Closed aspect closed 6 months ago

aspect commented 6 months ago

It appears that instead of gracefully handling errors, on Windows fdlimit is causing a crash resulting in the daemon halting with buffer overflow error without any kind of a panic, even setting RUST_BACKTRACE=1 is not helping. With the help of @Callidon on Discord #development we narrowed it down to the changes in #333. In this PR I've isolated the code to run on MacOS and Linux only (as me and @biryukovmaxim have tested it on these platforms manually).

aspect commented 6 months ago

We discovered that windows max fd value is 8192. Prepping another PR to handle this.