search

kaspanet / rusty-kaspa

Kaspa full-node reference implementation and related libraries in the Rust programming language
ISC License
470 stars 152 forks source link

Submitting TXs with incomplete keys must produce easily understandable error #452

Open coderofstuff opened 7 months ago

coderofstuff commented 7 months ago

Describe the bug When submitting a transaction where not all inputs are signed, the script engine produces a cryptic error that's not easily linkable to missing signatures in the signed transaction.

To Reproduce Steps to reproduce the behavior:

  1. Sign a tx but skip some needed keys
  2. Submit the tx to the node
  3. Get the error something like stack needs 1 but has 0

Expected behavior

  1. If there are unsigned inputs, either the submit or the script engine should yield a comprehensive error that allows the developer to figure out what the error actually is
IzioDev commented 2 months ago

can be closed

D-Stacks commented 2 months ago

can be closed

it should auto-close when the new release comes out. currently fix is still only on the dev branch, as far as i can tell.