feat: `--send-all` option

kaspanet / rusty-kaspa

Kaspa full-node reference implementation and related libraries in the Rust programming language

ISC License

491 stars 155 forks source link

feat: `--send-all` option #584

Open x100111010 opened 1 month ago

x100111010 commented 1 month ago

fix formatting and typos (and refactored text in docs/testnet11.md) 667ffb304539bdc5bfc47123d62b6f782f8b5a11
added --send-all option to send command, allowing users to send their entire mature balance minus an optional priority fee
retains feature parity between Go and Rust implementations (the Go wallet has --send-all) 07fd91b527643e39dd5c4c6971f9fe6fac0eb51e

KaffinPX commented 1 month ago

maybe a MAX special value instead of a param? @aspect

coderofstuff commented 1 month ago

@KaffinPX this being --send-all is probably to match what it used to be in the kaspad go wallet: https://github.com/kaspanet/kaspad/blob/6085d1fc84d71f74a571fad2b7e5b38413a3db5a/cmd/kaspawallet/config.go#L67

x100111010 commented 4 weeks ago

@KaffinPX this being --send-all is probably to match what it used to be in the kaspad go wallet: https://github.com/kaspanet/kaspad/blob/6085d1fc84d71f74a571fad2b7e5b38413a3db5a/cmd/kaspawallet/config.go#L67

Yes exactly! It was a missing feature in the rust wallet so I submitted this PR to maintain feature parity.