search

kasparsd / minit

A WordPress plugin to combine CSS and Javascript files.
GNU General Public License v2.0
286 stars 46 forks source link

Not minified #27

Closed username1290 closed 10 years ago

username1290 commented 10 years ago

Hi, trying the plugin and seems to work great (css is combined, js scripts don't break the site), it's only missing the minification. Are there any settings to enable uglifyJS or YUI compression?

Thanks

kasparsd commented 10 years ago

Minit does only concatination of the files. You need to use https://github.com/bjornjohansen/minit-yui by @bjornjohansen to minify them.

username1290 commented 10 years ago

thanks!

markoheijnen commented 10 years ago

Now I'm wondering why it's not included.

Edit: Nevermind after reading the requirements.

bjornjohansen commented 10 years ago

I have made a different plugin that doesn't require Java: https://github.com/bjornjohansen/minit-min

I don't think Minit should include any minification, though. That part should always have been done by the theme/plugin authors, thus making any minification in Minit a waste of CPU. I love the way Minit is made, as you can hook in your preferred way of minification if you really want to :-)

username1290 commented 10 years ago

Thanks, works great.

Agreed, one less plugin = less queries

On Mon, Aug 25, 2014 at 12:56 PM, Bjørn Johansen notifications@github.com wrote:

I have made a different plugin that doesn't require Java: https://github.com/bjornjohansen/minit-min

I don't think Minit should include any minification, though. That part should always have been done by the theme/plugin authors, thus making any minification in Minit a waste of CPU. I love the way Minit is made, as you can hook in your preferred way of minification if you really want to :-)

— Reply to this email directly or view it on GitHub https://github.com/kasparsd/minit/issues/27#issuecomment-53310777.