kasparsd / minit

A WordPress plugin to combine CSS and Javascript files.
GNU General Public License v2.0
286 stars 46 forks source link

Existing plugins #82

Closed ryanhellyer closed 7 years ago

ryanhellyer commented 8 years ago

I'm thinking it may be useful to add a list of links to existing extension plugins to the README.md file.

In particular, plugins (or code for) the following I think would be useful:

I'm aware of existing code for minification and CDN URLs, but not Cron purging.

ryanhellyer commented 8 years ago

Since I couldn't find an auto purge plugin, I made one ... https://github.com/ryanhellyer/minit-cron-purge

ryanhellyer commented 8 years ago

And here's another one for disabling Minit when logged in (and not on an admin page). https://github.com/ryanhellyer/minit-disable-for-logged-in-users

This was causing me some headaches with Beaver Builder. I think Beaver Builder was dynamically building JS and CSS files on the fly, and glitching out when Minit tried to serve the old concatenated file.

kasparsd commented 8 years ago

Thank @ryanhellyer! Would you like to open a pull request with the updated readme.md?

Secondly, I was wondering what is the use case for the Minit Cron Purge plugin? Is that mainly for keeping the minit cache folder clean?

kasparsd commented 8 years ago

@ryanhellyer Note that with static page caching you might end up with 404s on the those asset files that are still referenced in the HTML output.

szepeviktor commented 8 years ago

A wiki page page would be more suitable as users may edit it.

kasparsd commented 8 years ago

@szepeviktor That is a great suggestion. We could link to that wiki page from the readme then.

ryanhellyer commented 8 years ago

@kasparsd Yeah, I'm experiencing that darned static page caching problem ;)

My reasoning, was that I'm having some issues with the cache not being purged when it should be. Some plugins don't update their version numbers, and so the cache isn't purging when intended :/ But it is of course causing the issue you mentioned, which is problematic.

ryanhellyer commented 8 years ago

@kasparsd I suspect I'm meant to run Minit_Plugin::cache_bump() as you mentioned in another ticket instead of purging the whole cache. So I may refactor that plugin if that turns out to be the case.

EDIT: And now I see you have another ticket for adding support for that with do_action( 'minit-cache-version-bump' );

kasparsd commented 7 years ago

Fixed in #91.

szepeviktor commented 7 years ago

There are several minification addons but Minit-Pro is superior.

kasparsd commented 7 years ago

@szepeviktor I would like to list them all so a Wiki page would be awesome like you suggested. We can then change the readme to link to that Wiki page instead.

ryanhellyer commented 7 years ago

The Wiki page is here, in case anyone missed it: https://github.com/kasparsd/minit/wiki/Minit-Extensions