search

kasper / phoenix

A lightweight macOS window and app manager scriptable with JavaScript
https://kasper.github.io/phoenix/
Other
4.36k stars 128 forks source link

Cannot change Modal font size (weight?) #314

Closed l00sed closed 1 year ago

l00sed commented 1 year ago

I'm trying to shrink the font size from a Modal pop-up.

Modal.build({
  weight: 12,
  text: 'Test',
}).show();

Font size remains a large size, probably the default 24 points. Any advice?

kasper commented 1 year ago

@l00sed Hey, it seems like this is a regression that was introduced in 3.0.0. I’ll try to fix it as soon as possible. Thanks for the report!

l00sed commented 1 year ago

Awesome, thanks for taking a look @kasper. Loving Phoenix as someone coming from i3 on Linux. Glad you could confirm the bug.

kasper commented 1 year ago

Glad you like it, happy to hear! 😄

kasper commented 1 year ago

@l00sed As a workaround, set both the font and weight attributes. The bug happens only when using the default font and trying to adjust the weight.

kasper commented 1 year ago

Fixed in master.

l00sed commented 1 year ago

Hey @kasper I was trying to verify this by building master locally.

I'm using Node v19.7.0, NPM v9.6.2 I'm using Xcode 14.2 Build version 14C18 I get BUILD SUCCEEDED without any apparent errors.

After building, I copied the Phoenix.app to my applications directory. However, starting Phoenix from spotlight or the command line doesn't seem to work...

The Phoenix log doesn't report anything, and it looks like there's a broken process running if I check htop. But I'm not getting a response from Phoenix commands. Got any ideas I can try to help debug?

kasper commented 1 year ago

@l00sed Hey! That is likely related to signing. I would suggest that you just “Build and Run” from Xcode. You don’t need to replace your existing app. This will start a debug build of Phoenix. Then use the phoenix.debug.js file for testing.