search

kaspergrubbe / ruby-vnc

A library for interaction automation of servers via VNC
MIT License
31 stars 17 forks source link

Small improvements in README and ServerInitialisation #5

Closed kaspergrubbe closed 6 years ago

kaspergrubbe commented 7 years ago

Let me know what you think

aquasync commented 7 years ago

Looks good. My preference though would be not to change markup but rather rename to README.rdoc as I include that text as part of the built documentation (cf http://www.rubydoc.info/gems/ruby-vnc/). That's sufficient for github to at least format it nicely (see eg https://github.com/aquasync/ruby-ole).

kaspergrubbe commented 7 years ago

Did not know a lot about .rdoc, but you were right, it works! 👍

kaspergrubbe commented 6 years ago

Hi @aquasync

Could you merge this? Or is anything else wrong?

kaspergrubbe commented 6 years ago

PR lives on here: https://github.com/aquasync/ruby-vnc/pull/6