Use dotnet's built-in nuget. csproj Version element logic update

kaspersorensen / dotnet-maven-plugin

A Maven plugin for building dotnet projects based on project.json

Apache License 2.0

25 stars 15 forks source link

Closed RandyLarson closed 7 years ago

RandyLarson commented 7 years ago

Removed the dependence on an external nuget installation in favor of dotnet's built-in nuget support.
Adjusted Version handling
- Read and write to VersionPrefix and VersionSuffix
- Version tag is still supported when retrieving a version and VersionPrefix is absent.
- Adjust to ensure that version properties are contained within a PropertyGroup element.

kaspersorensen commented 7 years ago

Thanks for the patch! Only a few cosmetic remarks on this PR:

Would be nice if the files are formatted because there are some minor indentation inconsistencies.
The two NugetSomething classes should probably be renamed to DotnetNugetSomething
It would be nice to see the old unit test (and test .csproj) file still passing too. Couldn't we add another test using VersionPrefix and VersionSuffix, instead of changing the existing test?