search

kaspnilsson / curyte

http://curyte.com
1 stars 0 forks source link

Bella's account doesn't show up in search and I can't feature her lessons #125

Closed malvidah closed 2 years ago

malvidah commented 2 years ago

Describe the bug Some weirdness with bella's data. Can't find Isabella's account in search and also can't feature her lessons.

To Reproduce Steps to reproduce the behavior:

  1. Search Isabella
  2. No results
  3. Search Plate tectonics
  4. Click on Bella's accounts
  5. Open a lesson and click feature
  6. Nothing happens
  7. Click unfeature - nothing happens
  8. Lessons do not sure on explore even when "featured"

Expected behavior Isabella's account shows in search featured lessons show in explore

Screenshots

image

Desktop (please complete the following information): Mac OSX Chrome

kaspnilsson commented 2 years ago

Do you know how and when she signed up? Like with what provider, etc?

There's some very troubling stuff in the users table right now, lots of NULL columns that should not be NULL.

kaspnilsson commented 2 years ago

Did some triage, there are two bug reports in this single bug report that need to be fixed separately.

I can look into the first one, but I don't really think building out pagination is the best use of our time right now.

Should "Featured" instead show the ten most recent featured lessons?

malvidah commented 2 years ago

Yes. If featured shows most recent featured lessons that would be helpful for adding new featured lessons in. Also I think i tested unfeaturing a lesson and featuring bellas just to make sure. Both of hers were featured so i dont know that its an issue of pagination?

kaspnilsson commented 2 years ago

In order to test this, you would need to reduce the total number of featured lessons to less than ten and then try to feature her lesson. It sounds like you just unfeatured one, which still may not cut it because I believe you have featured a lot of your lessons, and we just never talked about the limit of 10 before

EDIT: Just troubleshot this myself. So I'm technically right about what I said above re pagination, but it's also true that I've broken the "feature lesson" flow when we merged the "harden auth" change -- I made it so that only lesson owners can edit their own lessons, and you need to edit the lesson in order to feature it.

Not a trivial fix, but IMO this could combine well with some of the chatting we've done about templates. Will think and fix fri

malvidah commented 2 years ago

Gotcha just tested and was coming back to say something confirming that. Let's take a look at it Friday because supporting Bella as an early user and featuring her work is important I think. Also for us to validate Curyte. One way to address this for now might just be to give me and you admin privileges to edit other people's lessons. something like authorization check for are you "owner" or "marvin" or "kasper"