search

kaspnilsson / curyte

http://curyte.com
1 stars 0 forks source link

Dev #131

Closed kaspnilsson closed 2 years ago

kaspnilsson commented 2 years ago

Things that are weird right now:

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/kaspnilsson/curyte/Ex2NYUkz8MxSNdVd8WLL9AT2Exuk
✅ Preview: https://curyte-git-dev-kaspnilsson.vercel.app

kaspnilsson commented 2 years ago

Still todo:

kaspnilsson commented 2 years ago
  • I preferred version with less placeholder and i think we might be able to get rid of highlight also although id like to test this (we can bring it back if it feels needed but i think it looks way cleaner without these) I've just been testing this with the medium editor for now and from what I remember on the PR before you changed it back.

Holding on this for now til we chat

  • the tool tip should just say something like add content NOT "add rich content.. etc etc"

Done

issue i have with the drag block menu now is that it gets stuck where it was before drag dropping and shows in strange places. This doesn't affect anything functionally only aesthetically so it is a pretty low priority issue.

Hmm, i havent seen this, can you reliably reproduce? Would love to fix, although it may have to happen outside of this change

this was not introduced in this PR but it is an issue that there is normal text in image blocks because it confuses people about placing elements between the text and the image.

Responded to that on the ticket, pasting here instead of addressing to consolidate the conversation: https://www.notion.so/curyte/Product-9af82c2cdafc44a0845fe2e3c4269bc1?p=b167f0ad20b64015a26925ca484c7a45

  • bit of lag on trying to drag an image that can be confusing (if you dont wait for a second on click and hold then the image wont drag drop)

Hmm, i havent seen this, and it sounds like a problem. can you reliably reproduce? Would love to fix, although it may have to happen outside of this change

just removing the tool tip to show how to drag drop isn't enough to let people know they can't drag drop tables.

Agreed, great point, updated!

would it be possible to add "copy" as an option to the drag block menu -- which just copies all the block contents to clipboard? this would be valuable especially if a lot of text was written or a whole table that you don't want to highlight. You could easily paste from here into the notebook.

Great idea, i do think this is possible! Let me have a look.

Would you mind if we added this in a follow up to this pull request? Its a great idea but could easily come a bit later