kassambara / fastqcr

fastqcr: Quality Control of Sequencing Data
http://www.sthda.com/english/rpkgs/fastqcr
68 stars 23 forks source link

getting NA in some modules of qc.aggregation function in new version (0.1.1) #12

Closed lida-R closed 5 years ago

lida-R commented 5 years ago

Hello,

I had the same issue with https://github.com/kassambara/fastqcr/issues/10 and based on your suggestion, updated to the newer version (0.1.1) and that error is gone and I was able to generate the qc metrics but some of the modules are NA while it worked with previous version (0.1.0) with same data! Do you have any thoughts? Thank you. qc$tot.seq [1] NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA [47] NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA [93] NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA NA qcstat<- qc_stats(qc)

qcstat sample pct.dup pct.gc tot.seq seq.length

1 C_rep1_R1 72.4 NA NA NA 2 C_rep1_R2 72.8 NA NA NA 3 C_rep2_R1 72.8 NA NA NA 4 C_rep2_R2 72.8 NA NA NA 5 C_rep3_R1 71.6 NA NA NA 6 C_rep3_R2 70.8 NA NA NA 7 P_rep1_R1 69.1 NA NA NA 8 P_rep1_R2 67.9 NA NA NA 9 P_rep2_R1 68.6 NA NA NA 10 P_rep2_R2 67.4 NA NA NA 11 P_rep3_R1 72.3 NA NA NA 12 P_rep3_R2 71.3 NA NA NA

cauwerx commented 5 years ago

Hi, I do have the same problem: with qc_aggregate(), I obtain no error message but once I open the resulting object, columns $tot.seq, $seq.length and pct.gc$ are filled with NAs... Did anyone manage to solve that issue?

kassambara commented 5 years ago

Fixed by the pull request https://github.com/kassambara/fastqcr/pull/11.

Please, install the latest developmental version of fastqcr and let me know if it works. readr 1.3 required.

devtools::install_github("kassambara/fastqcr")
cauwerx commented 5 years ago

Yes it worked! Thanks a lot!

lida-R commented 5 years ago

Thank you Kassambara, It worked for me too.

kassambara commented 5 years ago

thanks, so we can close this issue